Add separate min gas price option for txes with high gas wanted #777
+142
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
approved these changes
Jan 24, 2022
|
I think your right re: Not moving high gas thresholds as something done in consensus as well, and just keeping it in app.go. (Which this PR does) |
Codecov Report
@@ Coverage Diff @@
## main #777 +/- ##
==========================================
+ Coverage 19.96% 19.97% +0.01%
==========================================
Files 189 189
Lines 24542 24547 +5
==========================================
+ Hits 4899 4904 +5
Misses 18788 18788
Partials 855 855
Continue to review full report at Codecov.
|
ValarDragon
reviewed
Jan 25, 2022
hleb-albau
force-pushed
the
724_high_gas_txes_fee_options
branch
from
32cac99 to
24f9976
Compare
ValarDragon
pushed a commit
that referenced
this pull request
Feb 10, 2022
4 tasks
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #724
Description
Open questions to reviewer:
I think we should not move
HighGasTxThresholdparameter into consensus, but leave it just as a node option. If so, it's better to add it toapp.tomlOther
Do not waste time for choosing words, if something is wrong just said it straightforward, i am OK with that.
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer